Skip to content

Adding sw_dynamics to NamelistDefaults#136

Merged
FlorianDeconinck merged 5 commits into
NOAA-GFDL:developfrom
jjuyeonkim:20250424_rossby_1
May 13, 2025
Merged

Adding sw_dynamics to NamelistDefaults#136
FlorianDeconinck merged 5 commits into
NOAA-GFDL:developfrom
jjuyeonkim:20250424_rossby_1

Conversation

@jjuyeonkim
Copy link
Copy Markdown
Collaborator

Description
This is an initial step in porting a Fortran shallow water test to pace. Rossby-Haurwitz wave 4 test case found in tools/test_cases.F90 (shallow-water test 6) of the GFDL_atmos_cubed_sphere repo. This flag does nothing as of now, but it will eventually be used to

This PR will add a sw_dynamics flag default value to NamelistDefaults. This change is the result of the following PR: NOAA-GFDL/pyFV3#50

Fixes # (issue)
None

How Has This Been Tested?
This has been tested locally. It will eventually be tested more formally via this related PR: NOAA-GFDL/pace#112

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - I don't believe there is corresponding documentation for this change.
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included - This will eventually be tested via the following related PR: [On-hold] Rossby Test Case Initialization + Example Config pace#112

Comment thread ndsl/namelist.py
oelbert
oelbert previously approved these changes May 5, 2025
Copy link
Copy Markdown
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

You have a conflict - but it looks ok

Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianDeconinck FlorianDeconinck merged commit 287c674 into NOAA-GFDL:develop May 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants