Adding sw_dynamics to NamelistDefaults#136
Merged
FlorianDeconinck merged 5 commits intoMay 13, 2025
Merged
Conversation
7 tasks
oelbert
reviewed
Apr 28, 2025
Collaborator
|
You have a conflict - but it looks ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an initial step in porting a Fortran shallow water test to pace. Rossby-Haurwitz wave 4 test case found in tools/test_cases.F90 (shallow-water test 6) of the GFDL_atmos_cubed_sphere repo. This flag does nothing as of now, but it will eventually be used to
This PR will add a sw_dynamics flag default value to NamelistDefaults. This change is the result of the following PR: NOAA-GFDL/pyFV3#50
Fixes # (issue)
None
How Has This Been Tested?
This has been tested locally. It will eventually be tested more formally via this related PR: NOAA-GFDL/pace#112
Checklist: